From: jSTE0 <98854293+jSTE0@users.noreply.github.com>
Date: Mon, 28 Feb 2022 23:00:22 +0000 (+0000)
Subject: sdl: lock YUV overlay before clearing
X-Git-Url: https://notaz.gp2x.de/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=66ef1764f0a02a20c997eb43376d26b2e9260f0b;p=libpicofe.git

sdl: lock YUV overlay before clearing

The pixels pointer is not valid otherwise and leads to a segfault.
---

diff --git a/plat_sdl.c b/plat_sdl.c
index 6510fc1..97e2d29 100644
--- a/plat_sdl.c
+++ b/plat_sdl.c
@@ -101,11 +101,13 @@ int plat_sdl_change_video_mode(int w, int h, int force)
       || plat_target.vout_method == vout_mode_overlay2x) {
     int W = plat_target.vout_method == vout_mode_overlay2x && w == 320 ? 2*w : w;
     plat_sdl_overlay = SDL_CreateYUVOverlay(W, h, SDL_UYVY_OVERLAY, plat_sdl_screen);
-    if (plat_sdl_overlay != NULL) {
+    if (plat_sdl_overlay != NULL && SDL_LockYUVOverlay(plat_sdl_overlay) == 0) {
       if ((long)plat_sdl_overlay->pixels[0] & 3)
         fprintf(stderr, "warning: overlay pointer is unaligned\n");
 
       plat_sdl_overlay_clear();
+
+      SDL_UnlockYUVOverlay(plat_sdl_overlay);
     }
     else {
       fprintf(stderr, "warning: could not create overlay.\n");