From: gameblabla <gameblabla@protonmail.com>
Date: Wed, 10 Nov 2021 19:05:09 +0000 (+0100)
Subject: Remove CdlGetLocP hack
X-Git-Tag: r24l~542^2
X-Git-Url: https://notaz.gp2x.de/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6e72fb4d1ce087965afb024ccaa747d9146af091;p=pcsx_rearmed.git

Remove CdlGetLocP hack

This was added back in 2013 or so in PCSX Rearmed
and according to some tests against Tomb Raider 1 (which is affected by the GetLocP code),
it works properly without this hack.

So let's just remove it as we are now doing it properly.

Notaz also forgot the reason why he introduced the hack
in the first place, see :
https://github.com/notaz/pcsx_rearmed/pull/235#issuecomment-955026232
---

diff --git a/libpcsxcore/cdrom.c b/libpcsxcore/cdrom.c
index c09ccb10..76fd5456 100644
--- a/libpcsxcore/cdrom.c
+++ b/libpcsxcore/cdrom.c
@@ -812,9 +812,6 @@ void cdrInterrupt() {
 		case CdlGetlocP:
 			SetResultSize(8);
 			memcpy(&cdr.Result, &cdr.subq, 8);
-
-			if (!cdr.Play && !cdr.Reading)
-				cdr.Result[1] = 0; // HACK?
 			break;
 
 		case CdlReadT: // SetSession?