From: Nolan "Tempa Kyouran" Varani Date: Sat, 30 Sep 2017 12:17:30 +0000 (-0500) Subject: Prevent segfault in draw_key_config (#2) X-Git-Url: https://notaz.gp2x.de/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=e7f580052c03fa3f4603051c1b718be4bd8b2db7;p=libpicofe.git Prevent segfault in draw_key_config (#2) Its calculated `y` value can dip below zero This causes a segfault if used as an argument of `text_out16` --- diff --git a/menu.c b/menu.c index b40a5df..f1b1957 100644 --- a/menu.c +++ b/menu.c @@ -1381,7 +1381,8 @@ static void draw_key_config(const me_bind_action *opts, int opt_cnt, int player_ y = (g_menuscreen_h - 4 * me_mfont_h) / 2 - (2 + opt_cnt) * me_mfont_h / 2; if (x < me_mfont_w * 2) x = me_mfont_w * 2; - + if (y < 0) + y = 0; menu_draw_begin(1, 0); if (player_idx >= 0) text_out16(x, y, "Player %i controls", player_idx + 1);