spu: fix some skip accuracy issues

[pcsx_rearmed.git] / plugins / dfsound / reverb.c

/***************************************************************************\r
                          reverb.c  -  description\r
                             -------------------\r
    begin                : Wed May 15 2002\r
    copyright            : (C) 2002 by Pete Bernert\r
    email                : BlackDove@addcom.de\r
\r
 Portions (C) Gražvydas "notaz" Ignotas, 2010-2011\r
 Portions (C) SPU2-X, gigaherz, Pcsx2 Development Team\r
\r
 ***************************************************************************/\r
/***************************************************************************\r
 *                                                                         *\r
 *   This program is free software; you can redistribute it and/or modify  *\r
 *   it under the terms of the GNU General Public License as published by  *\r
 *   the Free Software Foundation; either version 2 of the License, or     *\r
 *   (at your option) any later version. See also the license.txt file for *\r
 *   additional informations.                                              *\r
 *                                                                         *\r
 ***************************************************************************/\r
\r
#include "stdafx.h"\r
\r
#define _IN_REVERB\r
\r
// will be included from spu.c\r
#ifdef _IN_SPU\r
\r
////////////////////////////////////////////////////////////////////////\r
// START REVERB\r
////////////////////////////////////////////////////////////////////////\r
\r
INLINE void StartREVERB(int ch)\r
{\r
 if(spu.s_chan[ch].bReverb && (spu.spuCtrl&0x80))      // reverb possible?\r
  {\r
   spu.s_chan[ch].bRVBActive=!!spu_config.iUseReverb;\r
  }\r
 else spu.s_chan[ch].bRVBActive=0;                     // else -> no reverb\r
}\r
\r
////////////////////////////////////////////////////////////////////////\r
\r
INLINE int rvb2ram_offs(int curr, int space, int iOff)\r
{\r
 iOff += curr;\r
 if (iOff >= 0x40000) iOff -= space;\r
 return iOff;\r
}\r
\r
// get_buffer content helper: takes care about wraps\r
#define g_buffer(var) \\r
 ((int)(signed short)spu.spuMem[rvb2ram_offs(curr_addr, space, rvb.n##var)])\r
\r
// saturate iVal and store it as var\r
#define s_buffer(var, iVal) \\r
 ssat32_to_16(iVal); \\r
 spu.spuMem[rvb2ram_offs(curr_addr, space, rvb.n##var)] = iVal\r
\r
#define s_buffer1(var, iVal) \\r
 ssat32_to_16(iVal); \\r
 spu.spuMem[rvb2ram_offs(curr_addr, space, rvb.n##var + 1)] = iVal\r
\r
////////////////////////////////////////////////////////////////////////\r
\r
// portions based on spu2-x from PCSX2\r
static void MixREVERB(int *SSumLR, int *RVB, int ns_to)\r
{\r
 int l_old = rvb.iRVBLeft;\r
 int r_old = rvb.iRVBRight;\r
 int curr_addr = rvb.CurrAddr;\r
 int space = 0x40000 - rvb.StartAddr;\r
 int l = 0, r = 0, ns;\r
\r
 for (ns = 0; ns < ns_to * 2; )\r
  {\r
   int IIR_ALPHA = rvb.IIR_ALPHA;\r
   int ACC0, ACC1, FB_A0, FB_A1, FB_B0, FB_B1;\r
   int mix_dest_a0, mix_dest_a1, mix_dest_b0, mix_dest_b1;\r
\r
   int input_L = RVB[ns]   * rvb.IN_COEF_L;\r
   int input_R = RVB[ns+1] * rvb.IN_COEF_R;\r
\r
   int IIR_INPUT_A0 = ((g_buffer(IIR_SRC_A0) * rvb.IIR_COEF) + input_L) >> 15;\r
   int IIR_INPUT_A1 = ((g_buffer(IIR_SRC_A1) * rvb.IIR_COEF) + input_R) >> 15;\r
   int IIR_INPUT_B0 = ((g_buffer(IIR_SRC_B0) * rvb.IIR_COEF) + input_L) >> 15;\r
   int IIR_INPUT_B1 = ((g_buffer(IIR_SRC_B1) * rvb.IIR_COEF) + input_R) >> 15;\r
\r
   int iir_dest_a0 = g_buffer(IIR_DEST_A0);\r
   int iir_dest_a1 = g_buffer(IIR_DEST_A1);\r
   int iir_dest_b0 = g_buffer(IIR_DEST_B0);\r
   int iir_dest_b1 = g_buffer(IIR_DEST_B1);\r
\r
   int IIR_A0 = iir_dest_a0 + ((IIR_INPUT_A0 - iir_dest_a0) * IIR_ALPHA >> 15);\r
   int IIR_A1 = iir_dest_a1 + ((IIR_INPUT_A1 - iir_dest_a1) * IIR_ALPHA >> 15);\r
   int IIR_B0 = iir_dest_b0 + ((IIR_INPUT_B0 - iir_dest_b0) * IIR_ALPHA >> 15);\r
   int IIR_B1 = iir_dest_b1 + ((IIR_INPUT_B1 - iir_dest_b1) * IIR_ALPHA >> 15);\r
\r
   s_buffer1(IIR_DEST_A0, IIR_A0);\r
   s_buffer1(IIR_DEST_A1, IIR_A1);\r
   s_buffer1(IIR_DEST_B0, IIR_B0);\r
   s_buffer1(IIR_DEST_B1, IIR_B1);\r
\r
   ACC0 = (g_buffer(ACC_SRC_A0) * rvb.ACC_COEF_A +\r
           g_buffer(ACC_SRC_B0) * rvb.ACC_COEF_B +\r
           g_buffer(ACC_SRC_C0) * rvb.ACC_COEF_C +\r
           g_buffer(ACC_SRC_D0) * rvb.ACC_COEF_D) >> 15;\r
   ACC1 = (g_buffer(ACC_SRC_A1) * rvb.ACC_COEF_A +\r
           g_buffer(ACC_SRC_B1) * rvb.ACC_COEF_B +\r
           g_buffer(ACC_SRC_C1) * rvb.ACC_COEF_C +\r
           g_buffer(ACC_SRC_D1) * rvb.ACC_COEF_D) >> 15;\r
\r
   FB_A0 = g_buffer(FB_SRC_A0);\r
   FB_A1 = g_buffer(FB_SRC_A1);\r
   FB_B0 = g_buffer(FB_SRC_B0);\r
   FB_B1 = g_buffer(FB_SRC_B1);\r
\r
   mix_dest_a0 = ACC0 - ((FB_A0 * rvb.FB_ALPHA) >> 15);\r
   mix_dest_a1 = ACC1 - ((FB_A1 * rvb.FB_ALPHA) >> 15);\r
\r
   mix_dest_b0 = FB_A0 + (((ACC0 - FB_A0) * rvb.FB_ALPHA - FB_B0 * rvb.FB_X) >> 15);\r
   mix_dest_b1 = FB_A1 + (((ACC1 - FB_A1) * rvb.FB_ALPHA - FB_B1 * rvb.FB_X) >> 15);\r
\r
   s_buffer(MIX_DEST_A0, mix_dest_a0);\r
   s_buffer(MIX_DEST_A1, mix_dest_a1);\r
   s_buffer(MIX_DEST_B0, mix_dest_b0);\r
   s_buffer(MIX_DEST_B1, mix_dest_b1);\r
\r
   l = (mix_dest_a0 + mix_dest_b0) / 2;\r
   r = (mix_dest_a1 + mix_dest_b1) / 2;\r
\r
   l = (l * rvb.VolLeft)  >> 15; // 15?\r
   r = (r * rvb.VolRight) >> 15;\r
\r
   SSumLR[ns++] += (l + l_old) / 2;\r
   SSumLR[ns++] += (r + r_old) / 2;\r
   SSumLR[ns++] += l;\r
   SSumLR[ns++] += r;\r
\r
   l_old = l;\r
   r_old = r;\r
\r
   curr_addr++;\r
   if (curr_addr >= 0x40000) curr_addr = rvb.StartAddr;\r
  }\r
\r
 rvb.iRVBLeft = l;\r
 rvb.iRVBRight = r;\r
 rvb.CurrAddr = curr_addr;\r
}\r
\r
static void MixREVERB_off(int *SSumLR, int ns_to)\r
{\r
 int l_old = rvb.iRVBLeft;\r
 int r_old = rvb.iRVBRight;\r
 int curr_addr = rvb.CurrAddr;\r
 int space = 0x40000 - rvb.StartAddr;\r
 int l = 0, r = 0, ns;\r
\r
 for (ns = 0; ns < ns_to * 2; )\r
  {\r
   l = (g_buffer(MIX_DEST_A0) + g_buffer(MIX_DEST_B0)) / 2;\r
   r = (g_buffer(MIX_DEST_A1) + g_buffer(MIX_DEST_B1)) / 2;\r
\r
   l = (l * rvb.VolLeft)  >> 15;\r
   r = (r * rvb.VolRight) >> 15;\r
\r
   SSumLR[ns++] += (l + l_old) / 2;\r
   SSumLR[ns++] += (r + r_old) / 2;\r
   SSumLR[ns++] += l;\r
   SSumLR[ns++] += r;\r
\r
   l_old = l;\r
   r_old = r;\r
\r
   curr_addr++;\r
   if (curr_addr >= 0x40000) curr_addr = rvb.StartAddr;\r
  }\r
\r
 rvb.iRVBLeft = l;\r
 rvb.iRVBRight = r;\r
 rvb.CurrAddr = curr_addr;\r
}\r
\r
static void prepare_offsets(void)\r
{\r
 int space = 0x40000 - rvb.StartAddr;\r
 int t;\r
 #define prep_offs(v) \\r
   t = rvb.v; \\r
   while (t >= space) \\r
     t -= space; \\r
   rvb.n##v = t\r
 #define prep_offs2(d, v1, v2) \\r
   t = rvb.v1 - rvb.v2; \\r
   while (t >= space) \\r
     t -= space; \\r
   rvb.n##d = t\r
\r
 prep_offs(IIR_SRC_A0);\r
 prep_offs(IIR_SRC_A1);\r
 prep_offs(IIR_SRC_B0);\r
 prep_offs(IIR_SRC_B1);\r
 prep_offs(IIR_DEST_A0);\r
 prep_offs(IIR_DEST_A1);\r
 prep_offs(IIR_DEST_B0);\r
 prep_offs(IIR_DEST_B1);\r
 prep_offs(ACC_SRC_A0);\r
 prep_offs(ACC_SRC_A1);\r
 prep_offs(ACC_SRC_B0);\r
 prep_offs(ACC_SRC_B1);\r
 prep_offs(ACC_SRC_C0);\r
 prep_offs(ACC_SRC_C1);\r
 prep_offs(ACC_SRC_D0);\r
 prep_offs(ACC_SRC_D1);\r
 prep_offs(MIX_DEST_A0);\r
 prep_offs(MIX_DEST_A1);\r
 prep_offs(MIX_DEST_B0);\r
 prep_offs(MIX_DEST_B1);\r
 prep_offs2(FB_SRC_A0, MIX_DEST_A0, FB_SRC_A);\r
 prep_offs2(FB_SRC_A1, MIX_DEST_A1, FB_SRC_A);\r
 prep_offs2(FB_SRC_B0, MIX_DEST_B0, FB_SRC_B);\r
 prep_offs2(FB_SRC_B1, MIX_DEST_B1, FB_SRC_B);\r
\r
#undef prep_offs\r
#undef prep_offs2\r
 rvb.dirty = 0;\r
}\r
\r
INLINE void REVERBDo(int *SSumLR, int *RVB, int ns_to)\r
{\r
 if (!rvb.StartAddr)                                   // reverb is off\r
 {\r
  rvb.iRVBLeft = rvb.iRVBRight = 0;\r
  return;\r
 }\r
\r
 if (spu.spuCtrl & 0x80)                               // -> reverb on? oki\r
 {\r
  if (unlikely(rvb.dirty))\r
   prepare_offsets();\r
\r
  MixREVERB(SSumLR, RVB, ns_to);\r
 }\r
 else if (rvb.VolLeft || rvb.VolRight)\r
 {\r
  if (unlikely(rvb.dirty))\r
   prepare_offsets();\r
\r
  MixREVERB_off(SSumLR, ns_to);\r
 }\r
 else                                                  // -> reverb off\r
 {\r
  // reverb runs anyway\r
  rvb.CurrAddr += ns_to / 2;\r
  while (rvb.CurrAddr >= 0x40000)\r
   rvb.CurrAddr -= 0x40000 - rvb.StartAddr;\r
 }\r
}\r
\r
////////////////////////////////////////////////////////////////////////\r
\r
#endif\r
\r
/*\r
-----------------------------------------------------------------------------\r
PSX reverb hardware notes\r
by Neill Corlett\r
-----------------------------------------------------------------------------\r
\r
Yadda yadda disclaimer yadda probably not perfect yadda well it's okay anyway\r
yadda yadda.\r
\r
-----------------------------------------------------------------------------\r
\r
Basics\r
------\r
\r
- The reverb buffer is 22khz 16-bit mono PCM.\r
- It starts at the reverb address given by 1DA2, extends to\r
  the end of sound RAM, and wraps back to the 1DA2 address.\r
\r
Setting the address at 1DA2 resets the current reverb work address.\r
\r
This work address ALWAYS increments every 1/22050 sec., regardless of\r
whether reverb is enabled (bit 7 of 1DAA set).\r
\r
And the contents of the reverb buffer ALWAYS play, scaled by the\r
"reverberation depth left/right" volumes (1D84/1D86).\r
(which, by the way, appear to be scaled so 3FFF=approx. 1.0, 4000=-1.0)\r
\r
-----------------------------------------------------------------------------\r
\r
Register names\r
--------------\r
\r
These are probably not their real names.\r
These are probably not even correct names.\r
We will use them anyway, because we can.\r
\r
1DC0: FB_SRC_A       (offset)\r
1DC2: FB_SRC_B       (offset)\r
1DC4: IIR_ALPHA      (coef.)\r
1DC6: ACC_COEF_A     (coef.)\r
1DC8: ACC_COEF_B     (coef.)\r
1DCA: ACC_COEF_C     (coef.)\r
1DCC: ACC_COEF_D     (coef.)\r
1DCE: IIR_COEF       (coef.)\r
1DD0: FB_ALPHA       (coef.)\r
1DD2: FB_X           (coef.)\r
1DD4: IIR_DEST_A0    (offset)\r
1DD6: IIR_DEST_A1    (offset)\r
1DD8: ACC_SRC_A0     (offset)\r
1DDA: ACC_SRC_A1     (offset)\r
1DDC: ACC_SRC_B0     (offset)\r
1DDE: ACC_SRC_B1     (offset)\r
1DE0: IIR_SRC_A0     (offset)\r
1DE2: IIR_SRC_A1     (offset)\r
1DE4: IIR_DEST_B0    (offset)\r
1DE6: IIR_DEST_B1    (offset)\r
1DE8: ACC_SRC_C0     (offset)\r
1DEA: ACC_SRC_C1     (offset)\r
1DEC: ACC_SRC_D0     (offset)\r
1DEE: ACC_SRC_D1     (offset)\r
1DF0: IIR_SRC_B1     (offset)\r
1DF2: IIR_SRC_B0     (offset)\r
1DF4: MIX_DEST_A0    (offset)\r
1DF6: MIX_DEST_A1    (offset)\r
1DF8: MIX_DEST_B0    (offset)\r
1DFA: MIX_DEST_B1    (offset)\r
1DFC: IN_COEF_L      (coef.)\r
1DFE: IN_COEF_R      (coef.)\r
\r
The coefficients are signed fractional values.\r
-32768 would be -1.0\r
 32768 would be  1.0 (if it were possible... the highest is of course 32767)\r
\r
The offsets are (byte/8) offsets into the reverb buffer.\r
i.e. you multiply them by 8, you get byte offsets.\r
You can also think of them as (samples/4) offsets.\r
They appear to be signed.  They can be negative.\r
None of the documented presets make them negative, though.\r
\r
Yes, 1DF0 and 1DF2 appear to be backwards.  Not a typo.\r
\r
-----------------------------------------------------------------------------\r
\r
What it does\r
------------\r
\r
We take all reverb sources:\r
- regular channels that have the reverb bit on\r
- cd and external sources, if their reverb bits are on\r
and mix them into one stereo 44100hz signal.\r
\r
Lowpass/downsample that to 22050hz.  The PSX uses a proper bandlimiting\r
algorithm here, but I haven't figured out the hysterically exact specifics.\r
I use an 8-tap filter with these coefficients, which are nice but probably\r
not the real ones:\r
\r
0.037828187894\r
0.157538631280\r
0.321159685278\r
0.449322115345\r
0.449322115345\r
0.321159685278\r
0.157538631280\r
0.037828187894\r
\r
So we have two input samples (INPUT_SAMPLE_L, INPUT_SAMPLE_R) every 22050hz.\r
\r
* IN MY EMULATION, I divide these by 2 to make it clip less.\r
  (and of course the L/R output coefficients are adjusted to compensate)\r
  The real thing appears to not do this.\r
\r
At every 22050hz tick:\r
- If the reverb bit is enabled (bit 7 of 1DAA), execute the reverb\r
  steady-state algorithm described below\r
- AFTERWARDS, retrieve the "wet out" L and R samples from the reverb buffer\r
  (This part may not be exactly right and I guessed at the coefs. TODO: check later.)\r
  L is: 0.333 * (buffer[MIX_DEST_A0] + buffer[MIX_DEST_B0])\r
  R is: 0.333 * (buffer[MIX_DEST_A1] + buffer[MIX_DEST_B1])\r
- Advance the current buffer position by 1 sample\r
\r
The wet out L and R are then upsampled to 44100hz and played at the\r
"reverberation depth left/right" (1D84/1D86) volume, independent of the main\r
volume.\r
\r
-----------------------------------------------------------------------------\r
\r
Reverb steady-state\r
-------------------\r
\r
The reverb steady-state algorithm is fairly clever, and of course by\r
"clever" I mean "batshit insane".\r
\r
buffer[x] is relative to the current buffer position, not the beginning of\r
the buffer.  Note that all buffer offsets must wrap around so they're\r
contained within the reverb work area.\r
\r
Clipping is performed at the end... maybe also sooner, but definitely at\r
the end.\r
\r
IIR_INPUT_A0 = buffer[IIR_SRC_A0] * IIR_COEF + INPUT_SAMPLE_L * IN_COEF_L;\r
IIR_INPUT_A1 = buffer[IIR_SRC_A1] * IIR_COEF + INPUT_SAMPLE_R * IN_COEF_R;\r
IIR_INPUT_B0 = buffer[IIR_SRC_B0] * IIR_COEF + INPUT_SAMPLE_L * IN_COEF_L;\r
IIR_INPUT_B1 = buffer[IIR_SRC_B1] * IIR_COEF + INPUT_SAMPLE_R * IN_COEF_R;\r
\r
IIR_A0 = IIR_INPUT_A0 * IIR_ALPHA + buffer[IIR_DEST_A0] * (1.0 - IIR_ALPHA);\r
IIR_A1 = IIR_INPUT_A1 * IIR_ALPHA + buffer[IIR_DEST_A1] * (1.0 - IIR_ALPHA);\r
IIR_B0 = IIR_INPUT_B0 * IIR_ALPHA + buffer[IIR_DEST_B0] * (1.0 - IIR_ALPHA);\r
IIR_B1 = IIR_INPUT_B1 * IIR_ALPHA + buffer[IIR_DEST_B1] * (1.0 - IIR_ALPHA);\r
\r
buffer[IIR_DEST_A0 + 1sample] = IIR_A0;\r
buffer[IIR_DEST_A1 + 1sample] = IIR_A1;\r
buffer[IIR_DEST_B0 + 1sample] = IIR_B0;\r
buffer[IIR_DEST_B1 + 1sample] = IIR_B1;\r
\r
ACC0 = buffer[ACC_SRC_A0] * ACC_COEF_A +\r
       buffer[ACC_SRC_B0] * ACC_COEF_B +\r
       buffer[ACC_SRC_C0] * ACC_COEF_C +\r
       buffer[ACC_SRC_D0] * ACC_COEF_D;\r
ACC1 = buffer[ACC_SRC_A1] * ACC_COEF_A +\r
       buffer[ACC_SRC_B1] * ACC_COEF_B +\r
       buffer[ACC_SRC_C1] * ACC_COEF_C +\r
       buffer[ACC_SRC_D1] * ACC_COEF_D;\r
\r
FB_A0 = buffer[MIX_DEST_A0 - FB_SRC_A];\r
FB_A1 = buffer[MIX_DEST_A1 - FB_SRC_A];\r
FB_B0 = buffer[MIX_DEST_B0 - FB_SRC_B];\r
FB_B1 = buffer[MIX_DEST_B1 - FB_SRC_B];\r
\r
buffer[MIX_DEST_A0] = ACC0 - FB_A0 * FB_ALPHA;\r
buffer[MIX_DEST_A1] = ACC1 - FB_A1 * FB_ALPHA;\r
buffer[MIX_DEST_B0] = (FB_ALPHA * ACC0) - FB_A0 * (FB_ALPHA^0x8000) - FB_B0 * FB_X;\r
buffer[MIX_DEST_B1] = (FB_ALPHA * ACC1) - FB_A1 * (FB_ALPHA^0x8000) - FB_B1 * FB_X;\r
\r
-----------------------------------------------------------------------------\r
*/\r
\r
// vim:shiftwidth=1:expandtab\r