From 4f13a57754959faa674e898d5d9147d302e72684 Mon Sep 17 00:00:00 2001 From: notaz Date: Sun, 27 Aug 2023 01:07:19 +0300 Subject: [PATCH] drc: adjust debugging code to work with hle bios --- libpcsxcore/new_dynarec/new_dynarec.c | 16 +++++ libpcsxcore/new_dynarec/patches/trace_drc_chk | 43 ++++--------- libpcsxcore/new_dynarec/patches/trace_intr | 64 +++++++++++-------- 3 files changed, 66 insertions(+), 57 deletions(-) diff --git a/libpcsxcore/new_dynarec/new_dynarec.c b/libpcsxcore/new_dynarec/new_dynarec.c index d7c24365..ede1f93c 100644 --- a/libpcsxcore/new_dynarec/new_dynarec.c +++ b/libpcsxcore/new_dynarec/new_dynarec.c @@ -4945,6 +4945,10 @@ static void drc_dbg_emit_do_cmp(int i, int ccadj_) emit_storereg(reg, 0); } } + if (dops[i].opcode == 0x0f) { // LUI + emit_movimm(cinfo[i].imm << 16, 0); + emit_storereg(dops[i].rt1, 0); + } emit_movimm(start+i*4,0); emit_writeword(0,&pcaddr); int cc = get_reg(regs[i].regmap_entry, CCREG); @@ -4960,8 +4964,18 @@ static void drc_dbg_emit_do_cmp(int i, int ccadj_) restore_regs(reglist); assem_debug("\\\\do_insn_cmp\n"); } +static void drc_dbg_emit_wb_dirtys(int i, const struct regstat *i_regs) +{ + // write-out non-consts, consts are likely different because of get_final_value() + if (i_regs->dirty & ~i_regs->loadedconst) { + assem_debug("/ drc_dbg_wb\n"); + wb_dirtys(i_regs->regmap, i_regs->dirty & ~i_regs->loadedconst); + assem_debug("\\ drc_dbg_wb\n"); + } +} #else #define drc_dbg_emit_do_cmp(x,y) +#define drc_dbg_emit_wb_dirtys(x,y) #endif // Used when a branch jumps into the delay slot of another branch @@ -5685,6 +5699,7 @@ static void cjump_assemble(int i, const struct regstat *i_regs) load_reg(regs[i].regmap,branch_regs[i].regmap,ROREG); load_regs(regs[i].regmap,branch_regs[i].regmap,CCREG,INVCP); ds_assemble(i+1,&branch_regs[i]); + drc_dbg_emit_wb_dirtys(i+1, &branch_regs[i]); cc=get_reg(branch_regs[i].regmap,CCREG); if(cc==-1) { emit_loadreg(CCREG,cc=HOST_CCREG); @@ -9114,6 +9129,7 @@ static int new_recompile_block(u_int addr) ds = assemble(i, ®s[i], cinfo[i].ccadj); + drc_dbg_emit_wb_dirtys(i, ®s[i]); if (dops[i].is_ujump) literal_pool(1024); else diff --git a/libpcsxcore/new_dynarec/patches/trace_drc_chk b/libpcsxcore/new_dynarec/patches/trace_drc_chk index 8de3ba1f..5dab3175 100644 --- a/libpcsxcore/new_dynarec/patches/trace_drc_chk +++ b/libpcsxcore/new_dynarec/patches/trace_drc_chk @@ -1,17 +1,17 @@ diff --git a/libpcsxcore/new_dynarec/new_dynarec.c b/libpcsxcore/new_dynarec/new_dynarec.c -index 2d3348e8..a85d2cd4 100644 +index ede1f93c..1c8965f0 100644 --- a/libpcsxcore/new_dynarec/new_dynarec.c +++ b/libpcsxcore/new_dynarec/new_dynarec.c -@@ -318,7 +318,7 @@ static struct compile_info +@@ -324,7 +324,7 @@ static struct compile_info int new_dynarec_hacks_old; int new_dynarec_did_compile; - #define HACK_ENABLED(x) ((new_dynarec_hacks | new_dynarec_hacks_pergame) & (x)) + #define HACK_ENABLED(x) ((NDHACK_NO_STALLS) & (x)) - extern int cycle_count; // ... until end of the timeslice, counts -N -> 0 + extern int cycle_count; // ... until end of the timeslice, counts -N -> 0 (CCREG) extern int last_count; // last absolute target, often = next_interupt -@@ -598,6 +598,7 @@ static int cycle_multiplier_active; +@@ -602,6 +602,7 @@ static int cycle_multiplier_active; static int CLOCK_ADJUST(int x) { @@ -19,7 +19,7 @@ index 2d3348e8..a85d2cd4 100644 int m = cycle_multiplier_active; int s = (x >> 31) | 1; return (x * m + s * 50) / 100; -@@ -752,6 +753,9 @@ static void *try_restore_block(u_int vaddr, u_int start_page, u_int end_page) +@@ -776,6 +777,9 @@ static noinline u_int generate_exception(u_int pc) // This is called from the recompiled JR/JALR instructions static void noinline *get_addr(u_int vaddr, int can_compile) { @@ -29,7 +29,7 @@ index 2d3348e8..a85d2cd4 100644 u_int start_page = get_page_prev(vaddr); u_int i, page, end_page = get_page(vaddr); void *found_clean = NULL; -@@ -7164,7 +7168,7 @@ static noinline void pass2_unneeded_regs(int istart,int iend,int r) +@@ -7157,7 +7161,7 @@ static noinline void pass2_unneeded_regs(int istart,int iend,int r) // R0 is always unneeded u|=1; // Save it @@ -38,7 +38,7 @@ index 2d3348e8..a85d2cd4 100644 gte_unneeded[i]=gte_u; /* printf("ur (%d,%d) %x: ",istart,iend,start+i*4); -@@ -8315,6 +8319,7 @@ static noinline void pass5a_preallocate1(void) +@@ -8299,6 +8303,7 @@ static noinline void pass5a_preallocate1(void) static noinline void pass5b_preallocate2(void) { int i, hr; @@ -46,22 +46,7 @@ index 2d3348e8..a85d2cd4 100644 for(i=0;isubCycleStep >= 0x10000); regs->subCycle += regs->subCycleStep; @@ -139,9 +124,9 @@ index e212d8a9..b98b694e 100644 regs->subCycle &= 0xffff; } -@@ -1341,8 +1341,14 @@ static void intShutdown() { - +@@ -1344,8 +1344,14 @@ static void intShutdown() { // single step (may do several ops in case of a branch or load delay) + // called by asm/dynarec void execI(psxRegisters *regs) { + extern int last_count; + void do_insn_cmp(void); diff --git a/libpcsxcore/new_dynarec/patches/trace_intr b/libpcsxcore/new_dynarec/patches/trace_intr index 1c7a36ea..3f01180d 100644 --- a/libpcsxcore/new_dynarec/patches/trace_intr +++ b/libpcsxcore/new_dynarec/patches/trace_intr @@ -1,5 +1,5 @@ diff --git a/libpcsxcore/new_dynarec/emu_if.c b/libpcsxcore/new_dynarec/emu_if.c -index 06612dbf..9a9d7b05 100644 +index f879ad8c..0ec366d0 100644 --- a/libpcsxcore/new_dynarec/emu_if.c +++ b/libpcsxcore/new_dynarec/emu_if.c @@ -323,13 +323,18 @@ static void ari64_shutdown() @@ -33,7 +33,7 @@ index 06612dbf..9a9d7b05 100644 { static psxRegisters oldregs; diff --git a/libpcsxcore/new_dynarec/pcsxmem.c b/libpcsxcore/new_dynarec/pcsxmem.c -index 190f8fc7..5feb7a02 100644 +index 1f37dc29..357f753e 100644 --- a/libpcsxcore/new_dynarec/pcsxmem.c +++ b/libpcsxcore/new_dynarec/pcsxmem.c @@ -289,6 +289,8 @@ static void write_biu(u32 value) @@ -87,13 +87,13 @@ index 18bd6a4e..bc2eb3f6 100644 count = _psxRcntRcount( index ); diff --git a/libpcsxcore/psxhw.c b/libpcsxcore/psxhw.c -index 27ddfeab..d7c6ff05 100644 +index 10a2695f..7e4a64da 100644 --- a/libpcsxcore/psxhw.c +++ b/libpcsxcore/psxhw.c -@@ -377,13 +377,14 @@ void psxHwWrite8(u32 add, u8 value) { - case 0x1f801803: cdrWrite3(value); break; +@@ -437,13 +437,14 @@ void psxHwWrite8(u32 add, u8 value) { + return; + } - default: + if (add < 0x1f802000) psxHu8(add) = value; #ifdef PSXHW_LOG @@ -106,7 +106,7 @@ index 27ddfeab..d7c6ff05 100644 #ifdef PSXHW_LOG PSXHW_LOG("*Known 8bit write at address %x value %x\n", add, value); #endif -@@ -506,6 +507,7 @@ void psxHwWrite16(u32 add, u16 value) { +@@ -565,6 +566,7 @@ void psxHwWrite16(u32 add, u16 value) { return; } @@ -114,7 +114,7 @@ index 27ddfeab..d7c6ff05 100644 psxHu16ref(add) = SWAPu16(value); #ifdef PSXHW_LOG PSXHW_LOG("*Unknown 16bit write at address %x value %x\n", add, value); -@@ -701,9 +703,9 @@ void psxHwWrite32(u32 add, u32 value) { +@@ -756,9 +758,9 @@ void psxHwWrite32(u32 add, u32 value) { return; case 0x1f801820: @@ -126,7 +126,7 @@ index 27ddfeab..d7c6ff05 100644 case 0x1f801100: #ifdef PSXHW_LOG -@@ -761,6 +763,7 @@ void psxHwWrite32(u32 add, u32 value) { +@@ -826,6 +828,7 @@ void psxHwWrite32(u32 add, u32 value) { return; } @@ -135,10 +135,10 @@ index 27ddfeab..d7c6ff05 100644 #ifdef PSXHW_LOG PSXHW_LOG("*Unknown 32bit write at address %x value %x\n", add, value); diff --git a/libpcsxcore/psxinterpreter.c b/libpcsxcore/psxinterpreter.c -index f473ddf6..49c4143b 100644 +index 5756bee5..4bf9248d 100644 --- a/libpcsxcore/psxinterpreter.c +++ b/libpcsxcore/psxinterpreter.c -@@ -237,7 +237,7 @@ static inline void addCycle(psxRegisters *regs) +@@ -238,7 +238,7 @@ static inline void addCycle(psxRegisters *regs) { assert(regs->subCycleStep >= 0x10000); regs->subCycle += regs->subCycleStep; @@ -147,7 +147,7 @@ index f473ddf6..49c4143b 100644 regs->subCycle &= 0xffff; } -@@ -434,7 +434,9 @@ static void doBranch(psxRegisters *regs, u32 tar, enum R3000Abdt taken) { +@@ -435,7 +435,9 @@ static void doBranch(psxRegisters *regs, u32 tar, enum R3000Abdt taken) { regs->CP0.n.Target = pc_final; regs->branching = 0; @@ -157,7 +157,7 @@ index f473ddf6..49c4143b 100644 } static void doBranchReg(psxRegisters *regs, u32 tar) { -@@ -959,7 +961,7 @@ void MTC0(psxRegisters *regs_, int reg, u32 val) { +@@ -960,7 +962,7 @@ void MTC0(psxRegisters *regs_, int reg, u32 val) { } } @@ -166,7 +166,15 @@ index f473ddf6..49c4143b 100644 // no exception static inline void psxNULLne(psxRegisters *regs) { -@@ -1167,18 +1169,20 @@ static void intReset() { +@@ -1120,6 +1122,7 @@ OP(psxHLE) { + } + psxHLEt[hleCode](); + branchSeen = 1; ++ psxRegs.cycle -= 2; + } + + static void (INT_ATTR *psxBSC[64])(psxRegisters *regs_, u32 code) = { +@@ -1169,18 +1172,20 @@ static void intReset() { static inline void execI_(u8 **memRLUT, psxRegisters *regs) { u32 pc = regs->pc; @@ -189,7 +197,7 @@ index f473ddf6..49c4143b 100644 dloadStep(regs); if (execBreakCheck(regs, pc)) -@@ -1187,6 +1191,8 @@ static inline void execIbp(u8 **memRLUT, psxRegisters *regs) { +@@ -1189,6 +1194,8 @@ static inline void execIbp(u8 **memRLUT, psxRegisters *regs) { regs->pc += 4; regs->code = fetch(regs, memRLUT, pc); psxBSC[regs->code >> 26](regs, regs->code); @@ -198,7 +206,7 @@ index f473ddf6..49c4143b 100644 } static void intExecute() { -@@ -1216,6 +1222,30 @@ void intExecuteBlock(enum blockExecCaller caller) { +@@ -1218,6 +1225,30 @@ void intExecuteBlock(enum blockExecCaller caller) { execI_(memRLUT, regs_); } @@ -229,7 +237,7 @@ index f473ddf6..49c4143b 100644 static void intClear(u32 Addr, u32 Size) { } -@@ -1244,7 +1274,7 @@ static void setupCop(u32 sr) +@@ -1246,7 +1277,7 @@ static void setupCop(u32 sr) else psxBSC[17] = psxCOPd; if (sr & (1u << 30)) @@ -238,7 +246,7 @@ index f473ddf6..49c4143b 100644 else psxBSC[18] = psxCOPd; if (sr & (1u << 31)) -@@ -1263,7 +1293,7 @@ void intApplyConfig() { +@@ -1265,7 +1296,7 @@ void intApplyConfig() { assert(psxSPC[26] == psxDIV || psxSPC[26] == psxDIV_stall); assert(psxSPC[27] == psxDIVU || psxSPC[27] == psxDIVU_stall); @@ -248,10 +256,10 @@ index f473ddf6..49c4143b 100644 psxBSC[50] = gteLWC2; psxBSC[58] = gteSWC2; diff --git a/libpcsxcore/psxmem.c b/libpcsxcore/psxmem.c -index 54219ae0..41168ced 100644 +index 42755e52..4fa4316b 100644 --- a/libpcsxcore/psxmem.c +++ b/libpcsxcore/psxmem.c -@@ -278,10 +278,13 @@ void psxMemOnIsolate(int enable) +@@ -289,10 +289,13 @@ void psxMemOnIsolate(int enable) : R3000ACPU_NOTIFY_CACHE_UNISOLATED, NULL); } @@ -265,7 +273,7 @@ index 54219ae0..41168ced 100644 t = mem >> 16; if (t == 0x1f80 || t == 0x9f80 || t == 0xbf80) { if ((mem & 0xffff) < 0x400) -@@ -307,6 +310,7 @@ u16 psxMemRead16(u32 mem) { +@@ -318,6 +321,7 @@ u16 psxMemRead16(u32 mem) { char *p; u32 t; @@ -273,7 +281,7 @@ index 54219ae0..41168ced 100644 t = mem >> 16; if (t == 0x1f80 || t == 0x9f80 || t == 0xbf80) { if ((mem & 0xffff) < 0x400) -@@ -332,6 +336,7 @@ u32 psxMemRead32(u32 mem) { +@@ -343,6 +347,7 @@ u32 psxMemRead32(u32 mem) { char *p; u32 t; @@ -281,7 +289,7 @@ index 54219ae0..41168ced 100644 t = mem >> 16; if (t == 0x1f80 || t == 0x9f80 || t == 0xbf80) { if ((mem & 0xffff) < 0x400) -@@ -359,6 +364,7 @@ void psxMemWrite8(u32 mem, u8 value) { +@@ -370,6 +375,7 @@ void psxMemWrite8(u32 mem, u8 value) { char *p; u32 t; @@ -289,7 +297,7 @@ index 54219ae0..41168ced 100644 t = mem >> 16; if (t == 0x1f80 || t == 0x9f80 || t == 0xbf80) { if ((mem & 0xffff) < 0x400) -@@ -386,6 +392,7 @@ void psxMemWrite16(u32 mem, u16 value) { +@@ -397,6 +403,7 @@ void psxMemWrite16(u32 mem, u16 value) { char *p; u32 t; @@ -297,7 +305,7 @@ index 54219ae0..41168ced 100644 t = mem >> 16; if (t == 0x1f80 || t == 0x9f80 || t == 0xbf80) { if ((mem & 0xffff) < 0x400) -@@ -413,6 +420,7 @@ void psxMemWrite32(u32 mem, u32 value) { +@@ -424,6 +431,7 @@ void psxMemWrite32(u32 mem, u32 value) { char *p; u32 t; @@ -305,7 +313,7 @@ index 54219ae0..41168ced 100644 // if ((mem&0x1fffff) == 0x71E18 || value == 0x48088800) SysPrintf("t2fix!!\n"); t = mem >> 16; if (t == 0x1f80 || t == 0x9f80 || t == 0xbf80) { -@@ -431,6 +439,8 @@ void psxMemWrite32(u32 mem, u32 value) { +@@ -442,6 +450,8 @@ void psxMemWrite32(u32 mem, u32 value) { #endif } else { if (mem == 0xfffe0130) { @@ -315,10 +323,10 @@ index 54219ae0..41168ced 100644 return; } diff --git a/libpcsxcore/r3000a.c b/libpcsxcore/r3000a.c -index dffbf6e7..0a3bdb65 100644 +index 48881068..47c40940 100644 --- a/libpcsxcore/r3000a.c +++ b/libpcsxcore/r3000a.c -@@ -124,6 +124,8 @@ void psxException(u32 cause, enum R3000Abdt bdt, psxCP0Regs *cp0) { +@@ -127,6 +127,8 @@ void psxException(u32 cause, enum R3000Abdt bdt, psxCP0Regs *cp0) { } void psxBranchTest() { -- 2.39.2