From 61a1bbbb76218c857318abbc75c7f8fac1188a41 Mon Sep 17 00:00:00 2001 From: notaz Date: Sun, 26 Nov 2023 21:39:08 +0200 Subject: [PATCH] libretro: drop the Frame Duping option Unclear what it was for, added in commit 0e5a7b7d5a4894754a73d0ea496b3b7b3f6b32d8 libretro/pcsx_rearmed#805 --- frontend/libretro.c | 16 ++-------------- frontend/libretro_core_options.h | 14 -------------- frontend/libretro_core_options_intl.h | 12 ------------ 3 files changed, 2 insertions(+), 40 deletions(-) diff --git a/frontend/libretro.c b/frontend/libretro.c index 0ed85339..d361be15 100644 --- a/frontend/libretro.c +++ b/frontend/libretro.c @@ -91,7 +91,6 @@ static int vout_width = 256, vout_height = 240, vout_pitch = 256; static int vout_fb_dirty; static int psx_w, psx_h; static bool vout_can_dupe; -static bool duping_enable; static bool found_bios; static bool display_internal_fps = false; static unsigned frame_count = 0; @@ -246,7 +245,7 @@ static void set_vout_fb() vout_pitch = vout_width; if (environ_cb(RETRO_ENVIRONMENT_GET_CURRENT_SOFTWARE_FRAMEBUFFER, &fb) && fb.format == RETRO_PIXEL_FORMAT_RGB565 - && vout_can_dupe && duping_enable) + && vout_can_dupe) { vout_buf_ptr = fb.data; if (fb.pitch / 2 != vout_pitch && fb.pitch != vout_width * 2) @@ -2109,17 +2108,6 @@ static void update_variables(bool in_flight) } #endif - var.value = NULL; - var.key = "pcsx_rearmed_duping_enable"; - - if (environ_cb(RETRO_ENVIRONMENT_GET_VARIABLE, &var) && var.value) - { - if (strcmp(var.value, "disabled") == 0) - duping_enable = false; - else if (strcmp(var.value, "enabled") == 0) - duping_enable = true; - } - var.value = NULL; var.key = "pcsx_rearmed_display_internal_fps"; @@ -3093,7 +3081,7 @@ void retro_run(void) frameskip_counter = 0; } - video_cb((vout_fb_dirty || !vout_can_dupe || !duping_enable) ? vout_buf_ptr : NULL, + video_cb((vout_fb_dirty || !vout_can_dupe) ? vout_buf_ptr : NULL, vout_width, vout_height, vout_pitch * 2); vout_fb_dirty = 0; } diff --git a/frontend/libretro_core_options.h b/frontend/libretro_core_options.h index 69100c37..25b2da4c 100644 --- a/frontend/libretro_core_options.h +++ b/frontend/libretro_core_options.h @@ -309,20 +309,6 @@ struct retro_core_option_v2_definition option_defs_us[] = { "enabled", #endif }, - { - "pcsx_rearmed_duping_enable", - "Frame Duping (Speedup)", - NULL, - "When enabled and supported by the libretro frontend, provides a small performance increase by directing the frontend to repeat the previous frame if the core has nothing new to display.", - NULL, - "video", - { - { "disabled", NULL }, - { "enabled", NULL }, - { NULL, NULL }, - }, - "enabled", - }, #ifdef THREAD_RENDERING { "pcsx_rearmed_gpu_thread_rendering", diff --git a/frontend/libretro_core_options_intl.h b/frontend/libretro_core_options_intl.h index d6658222..5e74450a 100644 --- a/frontend/libretro_core_options_intl.h +++ b/frontend/libretro_core_options_intl.h @@ -276,18 +276,6 @@ struct retro_core_option_v2_definition option_defs_tr[] = { }, #endif /* GPU_NEON */ - { - "pcsx_rearmed_duping_enable", - "Frame Duping", - NULL, - "Yeni bir veri yoksa, bir hızlandırma, son kareyi yeniden çizer/yeniden kullanır.", - NULL, - NULL, - { - { NULL, NULL }, - }, - NULL - }, { "pcsx_rearmed_display_internal_fps", "Dahili FPS'yi görüntüle", -- 2.39.2