use=OpBase(op,size);\r
if (op!=use) { OpUse(op,use); return 0; } // Use existing handler\r
\r
- OpStart(op,ea); Cycles=size<2?4:6;\r
- if(ea >= 0x10) {\r
- Cycles*=2;\r
-#if CYCLONE_FOR_GENESIS\r
- // This is same as in Starscream core, CLR uses only 6 cycles for memory EAs.\r
- // May be this is similar case as with TAS opcode, but this time the dummy\r
- // read is ignored somehow? Without this hack Fatal Rewind hangs even in Gens.\r
- if(type==1&&size<2) Cycles-=2;\r
-#endif\r
- }\r
+ OpStart(op,ea); Cycles=size<2?4:6;\r
+ if(ea >= 0x10) Cycles*=2;\r
\r
EaCalc (10,0x003f,ea,size,0,0);\r
\r
ot("\n");\r
}\r
\r
+ if (type==1) eawrite_check_addrerr=1;\r
EaWrite(10, 1,ea,size,0x003f,0,0);\r
\r
OpEnd(ea);\r
int OpSet(int op)\r
{\r
int cc=0,ea=0;\r
- int size=0,use=0;\r
+ int size=0,use=0,changed_cycles=0;\r
char *cond[16]=\r
{\r
"al","", "hi","ls","cc","cs","ne","eq",\r
use=OpBase(op,size);\r
if (op!=use) { OpUse(op,use); return 0; } // Use existing handler\r
\r
- OpStart(op,ea); Cycles=8;\r
+ changed_cycles=ea<8 && cc>=2;\r
+ OpStart(op,ea,0,changed_cycles); Cycles=8;\r
if (ea<8) Cycles=4;\r
\r
if (cc)\r
\r
ot("\n");\r
\r
+ eawrite_check_addrerr=1;\r
EaCalc (0,0x003f, ea,size,0,0);\r
EaWrite(0, 1, ea,size,0x003f,0,0);\r
\r
- OpEnd(ea);\r
+ opend_op_changes_cycles=changed_cycles;\r
+ OpEnd(ea,0);\r
return 0;\r
}\r
\r
ot("\n");\r
}\r
\r
- if (type==0 && dir) ot(" mov r3,r0 ;@ save old value for V flag calculation\n");\r
+ if (type==0 && dir) ot(" adds r3,r0,#0 ;@ save old value for V flag calculation, also clear V\n");\r
\r
ot(";@ Shift register:\n");\r
if (type==0) ot(" movs r0,r0,%s %s\n",dir?"asl":"asr",pct);\r
if (type==1) ot(" movs r0,r0,%s %s\n",dir?"lsl":"lsr",pct);\r
\r
- if (dir==0 && size<2)\r
- {\r
- ot(";@ restore after right shift:\n");\r
- ot(" mov r0,r0,lsl #%d\n",32-(8<<size));\r
- ot("\n");\r
- }\r
-\r
OpGetFlags(0,0);\r
if (usereg) { // store X only if count is not 0\r
ot(" cmp %s,#0 ;@ shifting by 0?\n",pct);\r
// count will never be 0 if we use immediate\r
ot(" str r9,[r7,#0x4c] ;@ Save X bit\n");\r
}\r
+ ot("\n");\r
+\r
+ if (dir==0 && size<2)\r
+ {\r
+ ot(";@ restore after right shift:\n");\r
+ ot(" movs r0,r0,lsl #%d\n",32-(8<<size));\r
+ if (type)\r
+ ot(" orrmi r9,r9,#0x80000000 ;@ Potentially missed N flag\n");\r
+ ot("\n");\r
+ }\r
\r
if (type==0 && dir) {\r
ot(";@ calculate V flag (set if sign bit changes at anytime):\n");\r
ot(" mov r1,#0x80000000\n");\r
ot(" ands r3,r3,r1,asr %s\n", pct);\r
ot(" cmpne r3,r1,asr %s\n", pct);\r
- ot(" biceq r9,r9,#0x10000000\n");\r
+ ot(" eoreq r1,r0,r3\n"); // above check doesn't catch (-1)<<(32+), so we need this\r
+ ot(" tsteq r1,#0x80000000\n");\r
ot(" orrne r9,r9,#0x10000000\n");\r
+ ot("\n");\r
}\r
-\r
- ot("\n");\r
}\r
\r
// --------------------------------------\r
\r
if (usereg)\r
{\r
- ot(";@ Reduce r2 until <0:\n");\r
- ot("Reduce_%.4x%s\n",op,ms?"":":");\r
- ot(" subs r2,r2,#%d\n",wide+1);\r
- ot(" bpl Reduce_%.4x\n",op);\r
- ot(" adds r2,r2,#%d ;@ Now r2=0-%d\n",wide+1,wide);\r
- ot(" beq norotx%.4x\n",op);\r
+ if (size==2)\r
+ {\r
+ ot(" subs r2,r2,#33\n");\r
+ ot(" addmis r2,r2,#33 ;@ Now r2=0-%d\n",wide);\r
+ }\r
+ else\r
+ {\r
+ ot(";@ Reduce r2 until <0:\n");\r
+ ot("Reduce_%.4x%s\n",op,ms?"":":");\r
+ ot(" subs r2,r2,#%d\n",wide+1);\r
+ ot(" bpl Reduce_%.4x\n",op);\r
+ ot(" adds r2,r2,#%d ;@ Now r2=0-%d\n",wide+1,wide);\r
+ }\r
+ ot(" beq norotx_%.4x\n",op);\r
ot("\n");\r
}\r
\r
\r
if (shift) ot(" mov r0,r0,lsr #%d ;@ Shift down\n",shift);\r
\r
- ot(";@ Rotate bits:\n");\r
- ot(" mov r3,r0,lsr r2 ;@ Get right part\n");\r
- ot(" rsbs r2,r2,#%d ;@ should also clear ARM V\n",wide+1);\r
- ot(" movs r0,r0,lsl r2 ;@ Get left part\n");\r
- ot(" orr r0,r3,r0 ;@ r0=Rotated value\n");\r
-\r
- ot(";@ Insert X bit into r2-1:\n");\r
+ ot("\n");\r
+ ot(";@ First get X bit (middle):\n");\r
ot(" ldr r3,[r7,#0x4c]\n");\r
- ot(" sub r2,r2,#1\n");\r
+ ot(" rsb r1,r2,#%d\n",wide);\r
ot(" and r3,r3,#0x20000000\n");\r
ot(" mov r3,r3,lsr #29\n");\r
- ot(" orr r0,r0,r3,lsl r2\n");\r
+ ot(" mov r3,r3,lsl r1\n");\r
+\r
+ ot(";@ Rotate bits:\n");\r
+ ot(" orr r3,r3,r0,lsr r2 ;@ Orr right part\n");\r
+ ot(" rsbs r2,r2,#%d ;@ should also clear ARM V\n",wide+1);\r
+ ot(" orrs r0,r3,r0,lsl r2 ;@ Orr left part, set flags\n");\r
ot("\n");\r
\r
if (shift) ot(" movs r0,r0,lsl #%d ;@ Shift up and get correct NC flags\n",shift);\r
OpGetFlags(0,!usereg);\r
- if (!shift) {\r
- ot(" tst r0,r0\n");\r
- ot(" bicne r9,r9,#0x40000000 ;@ make sure we didn't mess Z\n");\r
- }\r
if (usereg) { // store X only if count is not 0\r
ot(" str r9,[r7,#0x4c] ;@ if not 0, Save X bit\n");\r
ot(" b nozerox%.4x\n",op);\r
- ot("norotx%.4x%s\n",op,ms?"":":");\r
+ ot("norotx_%.4x%s\n",op,ms?"":":");\r
ot(" ldr r2,[r7,#0x4c]\n");\r
ot(" adds r0,r0,#0 ;@ Defines NZ, clears CV\n");\r
OpGetFlags(0,0);\r
}\r
\r
ot(";@ Rotate register:\n");\r
+ if (!dir) ot(" adds r0,r0,#0 ;@ first clear V and C\n"); // ARM does not clear C if rot count is 0\r
if (count<0)\r
{\r
- if (dir) ot(" rsbs %s,%s,#32\n",pct,pct);\r
+ if (dir) ot(" rsb %s,%s,#32\n",pct,pct);\r
ot(" movs r0,r0,ror %s\n",pct);\r
}\r
else\r
}\r
\r
OpGetFlags(0,0);\r
- if (!dir) ot(" bic r9,r9,#0x10000000 ;@ make suve V is clear\n");\r
if (dir)\r
{\r
+ ot(" bic r9,r9,#0x30000000 ;@ clear CV\n");\r
ot(";@ Get carry bit from bit 0:\n");\r
if (usereg)\r
{\r
else\r
ot(" tst r0,#1\n");\r
ot(" orrne r9,r9,#0x20000000\n");\r
- ot(" biceq r9,r9,#0x20000000\n");\r
- }\r
- else if (usereg)\r
- {\r
- // if we rotate something by 0, ARM doesn't clear C\r
- // so we need to detect that\r
- ot(" cmp %s,#0\n",pct);\r
- ot(" biceq r9,r9,#0x20000000\n");\r
}\r
ot("\n");\r
\r
int count=0,dir=0;\r
int size=0,usereg=0,type=0;\r
\r
- ea=0;\r
count =(op>>9)&7;\r
dir =(op>>8)&1;\r
size =(op>>6)&3;\r
// Use the same opcode for target registers:\r
use=op&~0x0007;\r
\r
- // As long as count is not 8, use the same opcode for all shift counts::\r
+ // As long as count is not 8, use the same opcode for all shift counts:\r
if (usereg==0 && count!=8 && !(count==1&&type==2)) { use|=0x0e00; count=-1; }\r
if (usereg) { use&=~0x0e00; count=-1; } // Use same opcode for all Dn\r
\r
if (op!=use) { OpUse(op,use); return 0; } // Use existing handler\r
\r
- OpStart(op); Cycles=size<2?6:8;\r
+ OpStart(op,ea,0,count<0); Cycles=size<2?6:8;\r
\r
EaCalc(10,0x0007, ea,size,1);\r
EaRead(10, 0, ea,size,0x0007,1);\r
\r
EaWrite(10, 0, ea,size,0x0007,1);\r
\r
- OpEnd();\r
+ opend_op_changes_cycles = (count<0);\r
+ OpEnd(ea,0);\r
\r
return 0;\r
}\r