cdrom: remove some old read-as-play logic master github/master
authornotaz <notasas@gmail.com>
Mon, 19 Jan 2026 01:59:58 +0000 (03:59 +0200)
committernotaz <notasas@gmail.com>
Mon, 19 Jan 2026 02:05:19 +0000 (04:05 +0200)
Supposedly tested in 2013 (55b8460a0e10da33133a98faeeb5b2375ef91dc0) but
maybe it was reading, not playing? Or maybe the mod chip affected this.

libretro/pcsx_rearmed#904

libpcsxcore/cdrom.c

index 9aa3693..a23e6ca 100644 (file)
@@ -865,7 +865,6 @@ void cdrInterrupt(void) {
                        }
                        break;
 
-               do_CdlPlay:
                case CdlPlay:
                        StopCdda();
                        StopReading();
@@ -1277,10 +1276,7 @@ void cdrInterrupt(void) {
 
                        Find_CurTrack(cdr.SetlocPending ? cdr.SetSector : cdr.SetSectorPlay);
 
-                       if (cdr.Mode & MODE_CDDA)
-                               // Read* acts as play for cdda tracks in cdda mode
-                               goto do_CdlPlay;
-                       if (cdr_stat.Type != CDRT_DATA) {
+                       if (cdr_stat.Type != CDRT_DATA && !(cdr.Mode & MODE_CDDA)) {
                                error = ERROR_INVALIDCMD;
                                goto set_error;
                        }