int changed = spu.regArea[rofs] != val;\r
spu.regArea[rofs] = val;\r
\r
- if (!changed && (ignore_dupe[rofs >> 5] & (1 << (rofs & 0x1f))))\r
+ if (!changed && (ignore_dupe[rofs >> 5] & (1u << (rofs & 0x1f))))\r
return;\r
// zero keyon/keyoff?\r
if (val == 0 && (r & 0xff8) == 0xd88)\r
return;\r
\r
- do_samples_if_needed(cycles, 0);\r
+ do_samples_if_needed(cycles, 0, 16);\r
\r
if(r>=0x0c00 && r<0x0d80) // some channel info?\r
{\r
{\r
//-------------------------------------------------//\r
case H_SPUaddr:\r
- spu.spuAddr = (unsigned long) val<<3;\r
+ spu.spuAddr = (unsigned int)val << 3;\r
//check_irq_io(spu.spuAddr);\r
break;\r
//-------------------------------------------------//\r
break;\r
//-------------------------------------------------//\r
case H_SPUctrl:\r
+ spu.spuStat = (spu.spuStat & ~0xbf) | (val & 0x3f) | ((val << 2) & 0x80);\r
+ spu.spuStat &= ~STAT_IRQ | val;\r
if (!(spu.spuCtrl & CTRL_IRQ)) {\r
- spu.spuStat&=~STAT_IRQ;\r
if (val & CTRL_IRQ)\r
schedule_next_irq();\r
}\r
break;\r
//-------------------------------------------------//\r
case H_SPUstat:\r
- spu.spuStat=val&0xf800;\r
+ //spu.spuStat=val&0xf800;\r
break;\r
//-------------------------------------------------//\r
case H_SPUReverbAddr:\r
goto upd_irq;\r
//-------------------------------------------------//\r
case H_SPUrvolL:\r
- spu.rvb->VolLeft=val;\r
+ spu.rvb->VolLeft = (int16_t)val;\r
break;\r
//-------------------------------------------------//\r
case H_SPUrvolR:\r
- spu.rvb->VolRight=val;\r
+ spu.rvb->VolRight = (int16_t)val;\r
break;\r
//-------------------------------------------------//\r
\r
case H_SPUmvolL:\r
- case H_SPUmvolR:\r
- if (val & 0x8000)\r
+ case H_SPUmvolR: {\r
+ int ofs = H_SPUcmvolL - H_SPUmvolL;\r
+ unsigned short *cur = ®AreaGet(r + ofs);\r
+ if (val & 0x8000) {\r
+ // this (for now?) lacks an update mechanism, so is instant\r
log_unhandled("w master sweep: %08lx %04x\n", reg, val);\r
+ int was_neg = (*cur >> 14) & 1;\r
+ int dec = (val >> 13) & 1;\r
+ int inv = (val >> 12) & 1;\r
+ *cur = (was_neg ^ dec ^ inv) ? 0x7fff : 0;\r
+ }\r
+ else\r
+ *cur = val << 1;\r
break;\r
+ }\r
\r
case 0x0dac:\r
if (val != 4)\r
//auxprintf("ER %d\n",val);\r
break;\r
//-------------------------------------------------//\r
- case H_SPUmvolL:\r
- //auxprintf("ML %d\n",val);\r
- break;\r
- //-------------------------------------------------//\r
- case H_SPUmvolR:\r
- //auxprintf("MR %d\n",val);\r
- break;\r
- //-------------------------------------------------//\r
case H_SPUMute1:\r
//auxprintf("M0 %04x\n",val);\r
break;\r
*/\r
//-------------------------------------------------//\r
case H_SPUon1:\r
+ spu.last_keyon_cycles = cycles;\r
+ do_samples_if_needed(cycles, 0, 2);\r
SoundOn(0,16,val);\r
break;\r
//-------------------------------------------------//\r
- case H_SPUon2:\r
+ case H_SPUon2:\r
+ spu.last_keyon_cycles = cycles;\r
+ do_samples_if_needed(cycles, 0, 2);\r
SoundOn(16,24,val);\r
break;\r
//-------------------------------------------------//\r
case H_SPUoff1:\r
+ if (cycles - spu.last_keyon_cycles < 786u) {\r
+ if (val & regAreaGet(H_SPUon1))\r
+ log_unhandled("koff1 %04x %d\n", val, cycles - spu.last_keyon_cycles);\r
+ val &= ~regAreaGet(H_SPUon1);\r
+ }\r
+ do_samples_if_needed(cycles, 0, 2);\r
SoundOff(0,16,val);\r
break;\r
//-------------------------------------------------//\r
case H_SPUoff2:\r
+ if (cycles - spu.last_keyon_cycles < 786u) {\r
+ if (val & regAreaGet(H_SPUon1))\r
+ log_unhandled("koff2 %04x %d\n", val, cycles - spu.last_keyon_cycles);\r
+ val &= ~regAreaGet(H_SPUon2);\r
+ }\r
+ do_samples_if_needed(cycles, 0, 2);\r
SoundOff(16,24,val);\r
break;\r
//-------------------------------------------------//\r
case H_CDLeft:\r
spu.iLeftXAVol=(int16_t)val;\r
- if(spu.cddavCallback) spu.cddavCallback(0,(int16_t)val);\r
+ //if(spu.cddavCallback) spu.cddavCallback(0,(int16_t)val);\r
break;\r
case H_CDRight:\r
spu.iRightXAVol=(int16_t)val;\r
- if(spu.cddavCallback) spu.cddavCallback(1,(int16_t)val);\r
+ //if(spu.cddavCallback) spu.cddavCallback(1,(int16_t)val);\r
break;\r
//-------------------------------------------------//\r
case H_FMod1:\r
ReverbOn(16,24,val);\r
break;\r
//-------------------------------------------------//\r
- case H_Reverb+0 : goto rvbd;\r
- case H_Reverb+2 : goto rvbd;\r
- case H_Reverb+4 : spu.rvb->IIR_ALPHA=(short)val; break;\r
- case H_Reverb+6 : spu.rvb->ACC_COEF_A=(short)val; break;\r
- case H_Reverb+8 : spu.rvb->ACC_COEF_B=(short)val; break;\r
- case H_Reverb+10 : spu.rvb->ACC_COEF_C=(short)val; break;\r
- case H_Reverb+12 : spu.rvb->ACC_COEF_D=(short)val; break;\r
- case H_Reverb+14 : spu.rvb->IIR_COEF=(short)val; break;\r
- case H_Reverb+16 : spu.rvb->FB_ALPHA=(short)val; break;\r
- case H_Reverb+18 : spu.rvb->FB_X=(short)val; break;\r
- case H_Reverb+20 : goto rvbd;\r
- case H_Reverb+22 : goto rvbd;\r
- case H_Reverb+24 : goto rvbd;\r
- case H_Reverb+26 : goto rvbd;\r
- case H_Reverb+28 : goto rvbd;\r
- case H_Reverb+30 : goto rvbd;\r
- case H_Reverb+32 : goto rvbd;\r
- case H_Reverb+34 : goto rvbd;\r
- case H_Reverb+36 : goto rvbd;\r
- case H_Reverb+38 : goto rvbd;\r
- case H_Reverb+40 : goto rvbd;\r
- case H_Reverb+42 : goto rvbd;\r
- case H_Reverb+44 : goto rvbd;\r
- case H_Reverb+46 : goto rvbd;\r
- case H_Reverb+48 : goto rvbd;\r
- case H_Reverb+50 : goto rvbd;\r
- case H_Reverb+52 : goto rvbd;\r
- case H_Reverb+54 : goto rvbd;\r
- case H_Reverb+56 : goto rvbd;\r
- case H_Reverb+58 : goto rvbd;\r
- case H_Reverb+60 : spu.rvb->IN_COEF_L=(short)val; break;\r
- case H_Reverb+62 : spu.rvb->IN_COEF_R=(short)val; break;\r
+ case H_Reverb + 0x00 : goto rvbd;\r
+ case H_Reverb + 0x02 : goto rvbd;\r
+ case H_Reverb + 0x04 : spu.rvb->vIIR = (signed short)val; break;\r
+ case H_Reverb + 0x06 : spu.rvb->vCOMB1 = (signed short)val; break;\r
+ case H_Reverb + 0x08 : spu.rvb->vCOMB2 = (signed short)val; break;\r
+ case H_Reverb + 0x0a : spu.rvb->vCOMB3 = (signed short)val; break;\r
+ case H_Reverb + 0x0c : spu.rvb->vCOMB4 = (signed short)val; break;\r
+ case H_Reverb + 0x0e : spu.rvb->vWALL = (signed short)val; break;\r
+ case H_Reverb + 0x10 : spu.rvb->vAPF1 = (signed short)val; break;\r
+ case H_Reverb + 0x12 : spu.rvb->vAPF2 = (signed short)val; break;\r
+ case H_Reverb + 0x14 : goto rvbd;\r
+ case H_Reverb + 0x16 : goto rvbd;\r
+ case H_Reverb + 0x18 : goto rvbd;\r
+ case H_Reverb + 0x1a : goto rvbd;\r
+ case H_Reverb + 0x1c : goto rvbd;\r
+ case H_Reverb + 0x1e : goto rvbd;\r
+ case H_Reverb + 0x20 : goto rvbd;\r
+ case H_Reverb + 0x22 : goto rvbd;\r
+ case H_Reverb + 0x24 : goto rvbd;\r
+ case H_Reverb + 0x26 : goto rvbd;\r
+ case H_Reverb + 0x28 : goto rvbd;\r
+ case H_Reverb + 0x2a : goto rvbd;\r
+ case H_Reverb + 0x2c : goto rvbd;\r
+ case H_Reverb + 0x2e : goto rvbd;\r
+ case H_Reverb + 0x30 : goto rvbd;\r
+ case H_Reverb + 0x32 : goto rvbd;\r
+ case H_Reverb + 0x34 : goto rvbd;\r
+ case H_Reverb + 0x36 : goto rvbd;\r
+ case H_Reverb + 0x38 : goto rvbd;\r
+ case H_Reverb + 0x3a : goto rvbd;\r
+ case H_Reverb + 0x3c : spu.rvb->vLIN = (signed short)val; break;\r
+ case H_Reverb + 0x3e : spu.rvb->vRIN = (signed short)val; break;\r
}\r
return;\r
\r
// READ REGISTER: called by main emu\r
////////////////////////////////////////////////////////////////////////\r
\r
-unsigned short CALLBACK SPUreadRegister(unsigned long reg)\r
+unsigned short CALLBACK SPUreadRegister(unsigned long reg, unsigned int cycles)\r
{\r
const unsigned long r = reg & 0xffe;\r
\r
{\r
case 12: // get adsr vol\r
{\r
- const int ch=(r>>4)-0xc0;\r
- if(spu.dwNewChannel&(1<<ch)) return 1; // we are started, but not processed? return 1\r
- if((spu.dwChannelsAudible&(1<<ch)) && // same here... we haven't decoded one sample yet, so no envelope yet. return 1 as well\r
- !spu.s_chan[ch].ADSRX.EnvelopeVol)\r
- return 1;\r
- return (unsigned short)(spu.s_chan[ch].ADSRX.EnvelopeVol>>16);\r
+ // this used to return 1 immediately after keyon to deal with\r
+ // some poor timing, but that causes Rayman 2 to lose track of\r
+ // it's channels on busy scenes and start looping some of them forever\r
+ const int ch = (r>>4) - 0xc0;\r
+ if (spu.s_chan[ch].bStarting)\r
+ do_samples_if_needed(cycles, 0, 2);\r
+ return (unsigned short)(spu.s_chan[ch].ADSRX.EnvelopeVol >> 16);\r
}\r
\r
case 14: // get loop address\r
return spu.spuCtrl;\r
\r
case H_SPUstat:\r
- return (spu.spuStat & ~0x3F) | (spu.spuCtrl & 0x3F);\r
+ return spu.spuStat;\r
\r
case H_SPUaddr:\r
return (unsigned short)(spu.spuAddr>>3);\r
\r
case H_SPUMute1:\r
case H_SPUMute2:\r
- log_unhandled("r isOn: %08lx\n", reg);\r
+ log_unhandled("spu r isOn: %08lx %04x\n", reg, regAreaGet(r));\r
+ break;\r
+\r
+ case H_SPUmvolL:\r
+ case H_SPUmvolR:\r
+ log_unhandled("spu r mvol: %08lx %04x\n", reg, regAreaGet(r));\r
break;\r
\r
case 0x0dac:\r
\r
default:\r
if (r >= 0xda0)\r
- log_unhandled("spu r %08lx\n", reg);\r
+ log_unhandled("spu r %08lx %04x\n", reg, regAreaGet(r));\r
break;\r
}\r
\r
if((val&1) && regAreaGetCh(ch, 6)) // mmm... start has to be set before key on !?!\r
{\r
spu.s_chan[ch].bIgnoreLoop = 0;\r
+ spu.s_chan[ch].bStarting = 1;\r
spu.dwNewChannel|=(1<<ch);\r
}\r
}\r
static void SoundOff(int start,int end,unsigned short val)\r
{\r
int ch;\r
- for(ch=start;ch<end;ch++,val>>=1) // loop channels\r
+ for (ch = start; val && ch < end; ch++, val >>= 1) // loop channels\r
{\r
if(val&1)\r
{\r
spu.s_chan[ch].iRawPitch = NP;\r
spu.s_chan[ch].sinc = NP << 4;\r
spu.s_chan[ch].sinc_inv = 0;\r
- spu.s_chan[ch].bNewPitch = 1;\r
\r
// don't mess spu.dwChannelsAudible as adsr runs independently\r
}\r
spu.s_chan[ch].bReverb=val&1; // -> reverb on/off\r
}\r
}\r
+\r
+// vim:shiftwidth=1:expandtab\r