Remove CdlGetlocP hack. (#235)
authorgameblabla <gameblabla@users.noreply.github.com>
Fri, 29 Oct 2021 20:22:25 +0000 (20:22 +0000)
committerGitHub <noreply@github.com>
Fri, 29 Oct 2021 20:22:25 +0000 (23:22 +0300)
This was added back in 2013 or so in PCSX Rearmed
and according to some tests against Tomb Raider 1 (which
is affected by the GetLocP code),
it works properly without this hack.

So let's just remove it as we are now doing it properly.
(Besides, Duckstation and mednafen don't have this hack)

libpcsxcore/cdrom.c

index 016b993..753c512 100644 (file)
@@ -841,9 +841,6 @@ void cdrInterrupt() {
                case CdlGetlocP:
                        SetResultSize(8);
                        memcpy(&cdr.Result, &cdr.subq, 8);
-
-                       if (!cdr.Play && !cdr.Reading)
-                               cdr.Result[1] = 0; // HACK?
                        break;
 
                case CdlReadT: // SetSession?